Feature: dynamic CSS classes with Hash

[Spone]

Hello,

I'd like to suggest a new feature. The idea would be to allow generating CSS classes dynamically based on a Hash:

div(class={one: true, two: false, three: true})

would render:

<div class="one three"></div>

I currently use this gem for that: https://github.com/komposable/klassnames but it would be great to have this feature included in Slim!

Let me know what you think.

[minad]

I don't think it is a good idea to complicate the Slim syntax for this feature, given that you can simply use a function like the classnames function from the gem you mentioned.

[Spone]

Thanks for taking the time to reply.

Since then, I've considered another approach: Spone#1
If you have a couple minutes to let me know if you would be open to a PR for this, I'd very much appreciate it!

[minad]

This sounds like a useful generalization. My suggestion would be to make :attr a function instead which returns a pair of an attribute name and an attribute value. I would be happy to accept a PR which adds this. But it is also necessary that you update the documentation accordingly and add test cases.

[Spone]

Thank you! I'll try to get back to it!

[Spone]

My suggestion would be to make :attr a function instead which returns a pair of an attribute name and an attribute value.

Just to clarify, do you mean having:

Slim::Parser.options[:shortcut].update({
  '~' => { attr: ->(v) { ["class", "styles['#{v}']"] } }
})

instead of:

Slim::Parser.options[:shortcut].update({
  '~' => { attr: "class", attr_value: ->(v) { "styles['#{v}']" } }
})

[minad]

Just to clarify, do you mean having:

Yes. This generalizes attr instead of adding a new option attr_value.