Some incorrect highlighting #3

Closed
dre3k opened this Issue Mar 29, 2011 · 5 comments

Comments

Projects
None yet
3 participants
@dre3k

dre3k commented Mar 29, 2011

It's easy to see in the following example:
h1 this is header h1
p this is paragraph p

div
  h1 this is header h1
  p this is paragraph p 

vim-slim incorrect highlighting example

@stefanoverna

This comment has been minimized.

Show comment Hide comment
@stefanoverna

stefanoverna Sep 11, 2011

Contributor

+1

Contributor

stefanoverna commented Sep 11, 2011

+1

@stefanoverna

This comment has been minimized.

Show comment Hide comment
@stefanoverna

stefanoverna Dec 12, 2011

Contributor

i guess the problem is due to the fact that HTML is simply included to the syntax, so any tag name gets highlighted randomly. is there anyone out there with the knowledge to implement a real syntax? it should not be too difficult, considering that large parts of the code can probably be pasted from https://github.com/tpope/vim-haml/blob/master/syntax/haml.vim

Contributor

stefanoverna commented Dec 12, 2011

i guess the problem is due to the fact that HTML is simply included to the syntax, so any tag name gets highlighted randomly. is there anyone out there with the knowledge to implement a real syntax? it should not be too difficult, considering that large parts of the code can probably be pasted from https://github.com/tpope/vim-haml/blob/master/syntax/haml.vim

@stonean

This comment has been minimized.

Show comment Hide comment
@stonean

stonean Dec 13, 2011

Owner

It's not quite as simple as copying haml.vim. Slim's syntax doesn't have the same constraints and therefore makes it a bit more difficult.

Pull requests are very welcome.

Owner

stonean commented Dec 13, 2011

It's not quite as simple as copying haml.vim. Slim's syntax doesn't have the same constraints and therefore makes it a bit more difficult.

Pull requests are very welcome.

@stefanoverna

This comment has been minimized.

Show comment Hide comment
@stefanoverna

stefanoverna Dec 13, 2011

Contributor

I'll make a try Andrew :) thanks

Contributor

stefanoverna commented Dec 13, 2011

I'll make a try Andrew :) thanks

@stonean

This comment has been minimized.

Show comment Hide comment
@stonean

stonean Dec 16, 2011

Owner

corrected with @stefanoverna 's great work

Owner

stonean commented Dec 16, 2011

corrected with @stefanoverna 's great work

@stonean stonean closed this Dec 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment