Sigil L for safe Slime HTML #63
Conversation
There was a problem hiding this comment.
This is wonderful @the-mikedavis! I want to give @Rakoth a chance to look this over 😁
There was a problem hiding this comment.
Sorry for long wait @the-mikedavis
@doomspork I didn't get any notifications about your review request =(
lib/phoenix_slime.ex
Outdated
|
|
||
| iex> import PhoenixSlime | ||
| iex> ~L"\"" | ||
| ...> p hello #{"world"} |
There was a problem hiding this comment.
I believe, it should be
| ...> p hello #{"world"} | |
| ...> p hello \#{"world"} |
so interpolation is actually present in string at sigil compile time
lib/phoenix_slime.ex
Outdated
| @doc """ | ||
| Provides the `~l` sigil with HTML safe Slime syntax inside source files. | ||
|
|
||
| Raises on attempts to interpolate with `\#{}`. Use `~L` to interpolate. |
There was a problem hiding this comment.
I think it is misleading, ~L does not allow to interpolate values, instead interpolation processed by slime parser
There was a problem hiding this comment.
Ah I see your point @Rakoth. Do you think we should remove the ~l or just rephrase the documentation?
There was a problem hiding this comment.
It is now matches the behavior of the ~E sigil, so lets just rephrase the documentation
There was a problem hiding this comment.
@Rakoth I've changed up the documentation and the error message. How does this look?
|
No worries @Rakoth! I have been unbelievably busy with family and work, I know we all get busy 😁 |
|
@the-mikedavis do you mind if I squash commits before merge? |
|
@Rakoth 👍 |
Closes #61. Sorry about the wait.
This is pretty much the same as in EEx. It just takes the extra step to do the slime precompilation. There is one snag that the precompilation causes. For either
~eor~Esigils in EEx, interpolation isn't allowed. The precompilation doesn't prevent interpolation, so if we use~L, we can interpolate. I think it's kind of nice to be able to interpolate, but it might be a little confusing if someone wanted to use the#{@assign}syntax in the template.