ABCL introspect 201703a #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the functionality in this patch requires the as yet unreleased abcl-1.5.0 which may be built from the [abcl-1.5.0-dev][abcl-source-svn] for which [gitlab.common-lisp.net provides a convenient git bridge](https://gitlab.common-lisp.net/abcl/abcl) [abcl-source-svn]: svn://abcl.org/svn/trunk/abcl Enable goto source location to find definitions in JAR archives. For primitives compiled from Java source, return implementation source location designated by the logical pathname associated with 'SYS:SRC'. Finding functions and methods works well, other than when methods are defined as part of a DEFGENERIC form, or implicitly as with :report on condition defining PRINT-OBJECT. FIND-DEFINITIONS include symbols and specials defined in Java. Redirect source lookup to system jar if it's not where it claims to be. Show stack trace when inspecting Java conditions. Implement an inspector for Java classes. Make line labels in inspector (:labels) so they display nicely. Allow find definitions to be called even if the symbol isn't found in the current package, if *find-definitions-all-packages* is t (as it will be for ABCL). Default nil Print internal variables in Java stack traces. Prettier function name if we can glean information about otherwise anonymous function. Fix so that edit slot action in clos object inspector works. Tweak to invoke hyperspec in inspector (offered in symbol browser if a CL symbol) - *slime-inspector-hyperspec-in-browser* if t shows hyperspec in emacs buffer despite setting of browse-url-browser-function. Don't use the ABCL native printObject for frames, so we can get prettier function display. Compile DEFIMPLEMENTATION forms so that they are visible to edit definition. Fix source-location (used by view frame source) to work in general and in particular for local function - go to the source of their owner. Don't show bogus locals for Java stack frames.
This should be a non-functional change from a behavior perspective, for which there are unfortunately no non-interactive tests.
Uncertain if this is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consolidates Alan Ruttenberg's Winter 2016 changes that drastically improve the inspection of code with the abcl implementation.
I have tested that this code works with both abcl-1.4.0 and abcl-1.5.0-dev (aka "abcl trunk").
The code works independently of a bunch of SLIME additions from Alan Ruttenberg which will be issues a separate pull request (c.f. #376)