Rework swank.asd to produce actual compilation artifact #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(of course the unspoken system that does not dump images is ecl ^_^) |
Until now swank.asd compiled the system files when it was loaded. That is roughly compatible with what slime does when loading swank, however that is not useful for swank that is loaded as a standalone system without slime. Instead of producing compilation artifacts that may be further processed by asdf (either in bundle-op or otherwise) it puts fasls in ~/.slime directory. When a system "foo" depends on "swank" then before the system "foo" is loaded swank is loaded itself. However if we only compile systems and then try to load a bundle then all we have is the swank-loader artifact - no "SWANK" package nor nothing. This issue has been unnoticed because usually people dump images instead of having separate compilation and loading steps. This commit defines two systems "swank" and "swank-exts" - one for the core runtime and one for contribs.
dkochmanski
force-pushed
the
master
branch
2 times, most recently
from
8b9b0bd
to
3aec0fc
Compare
|
I've removed fully the kludge that prevented reloading of swank if it is in the different location than the version already loaded in the image. If the user has swank in a custom location and tries to load it, then it is either a deliberate action or broken environment. I'd rather punish users with broken environment than users who know what they are doing (i.e by specifying swank as a dependency). |
This inhibition is tailored for possibly incompatible slime/swank instances (according to the comment at the top of the file), so there is no need to prevent loading a different swank version in the image without slime.
Don't prevent reloading the system "swank" even if it was previously loaded by emacs. If the user wants to reload swank from a different directory then so be it. Otherwise we can't compile bundles that depend on slime.
|
Merging as is now. c.f https://irclog.tymoon.eu/libera/%23slime?around=1678778419#1678778419 |
easye
added a commit
to easye/slime
that referenced
this pull request
May 1, 2023
easye
pushed a commit
to easye/slime
that referenced
this pull request
May 5, 2023
* Rework swank.asd to produce actual compilation artifact Until now swank.asd compiled the system files when it was loaded. That is roughly compatible with what slime does when loading swank, however that is not useful for swank that is loaded as a standalone system without slime. Instead of producing compilation artifacts that may be further processed by asdf (either in bundle-op or otherwise) it puts fasls in ~/.slime directory. When a system "foo" depends on "swank" then before the system "foo" is loaded swank is loaded itself. However if we only compile systems and then try to load a bundle then all we have is the swank-loader artifact - no "SWANK" package nor nothing. This issue has been unnoticed because usually people dump images instead of having separate compilation and loading steps. This commit defines two systems "swank" and "swank-exts" - one for the core runtime and one for contribs. * swank.asd: inhibit loading swank only when started from emacs This inhibition is tailored for possibly incompatible slime/swank instances (according to the comment at the top of the file), so there is no need to prevent loading a different swank version in the image without slime. * Remove locking of the system "swank" Don't prevent reloading the system "swank" even if it was previously loaded by emacs. If the user wants to reload swank from a different directory then so be it. Otherwise we can't compile bundles that depend on slime. * meta: add an entry to NEWS section
easye
added a commit
to easye/slime
that referenced
this pull request
May 15, 2023
WARNING: Since ABCL's Gray stream implementation has long been unusable as the basis of communication with SWANK, this doesn't currently work with any released or unreleased version of the Bear. <slime#760>
easye
added a commit
to easye/slime
that referenced
this pull request
Jun 5, 2023
When loaded via ASDF, we align the swank-loader:*source-directory* and swank-loader:*fasl-directory* special variables to the appropriate values. This restores the ability to launch a Swank server from a Lisp image which has loaded SLIME via ASDF. See <slime@dd179f4> and <slime#760>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now swank.asd compiled the system files when it was loaded. That is roughly compatible with what slime does when loading swank, however that is not useful for swank that is loaded as a standalone system without slime. Instead of producing compilation artifacts that may be further processed by asdf (either in bundle-op or otherwise) it puts fasls in ~/.slime directory.
When a system "foo" depends on "swank" then before the system "foo" is loaded swank is loaded itself. However if we only compile systems and then try to load a bundle then all we have is the swank-loader artifact - no "SWANK" package nor nothing. This issue has been unnoticed because usually people dump images instead of having separate compilation and loading steps.
This commit defines two systems "swank" and "swank-exts" - one for the core runtime and one for contribs.