Align compilation artifact paths in swank-loader with ASDF #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loaded via ASDF, we align the swank-loader:*source-directory* and swank-loader:*fasl-directory* special variables to the appropriate values. This restores the ability to launch a Swank server from a Lisp image which has loaded SLIME via ASDF. See <slime@dd179f4> and <slime#760>.
dkochmanski
requested changes
Jun 9, 2023
Nomimally, I would have expected ASDF to normalize this via the FrobCase setting of its reader, but this can't hurt. Addresses <slime#771 (comment)>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loaded via ASDF, we align the
swank-loader:*source-directory*andswank-loader:*fasl-directory*special variables to the appropriate values. This restores the ability to launch a Swank server from a Lisp image which has loaded SLIME via ASDF.See
dd179f4 and #760.
--
In debugging ABCL/SLIME, I often start ABCL under a JVM debugger, using ASDF to locate and load SLIME. Without these changes, @dkochmanski's recent work on
swank.asdbroke this usage.