Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is slimgems vulnerable to the issue that rubygems-pwn exploits? #10

Closed
practicingruby opened this issue Sep 7, 2011 · 4 comments
Closed

Comments

@practicingruby
Copy link

Not sure if the issue listed below affects slimgems, but if it does, please fix and cut a security release:

http://www.rubyflow.com/items/6419-rubygems-pwn-a-vulnerability-in-rubygems-currently-being-fixe

@lsegal
Copy link
Contributor

lsegal commented Sep 7, 2011

Thanks. We'll have to check. If it is, we will certainly fix.

I just want to point out, however, that "remote execution" is very easy to achieve even without a vulnerability, so the actual practicality of such an exploit isn't inordinately higher than the regular way of performing arbitrary commands, which is extremely possible and easy to do in a gem install. Basically, this is no different than having someone gem install a gem with native extensions, since that already executes/evaluates an extconf.rb or Makefile, both of which can easily allow arbitrary execution. So while we certainly want to limit where people can execute code, this vuln. doesn't actually expose a new attack vector.

Again, that's not to say we aren't prioritizing a fix. Just trying to clarify the issue and minimize any undue panic.

@practicingruby
Copy link
Author

Yeah, while I didn't dig into the details, that's roughly what I thought on a first read. That said, it's likely that some folks either have policies about not using gems with extensions, or scrutinize them more carefully on audit, and may not be expecting the issue to show up from this angle.

The main reason I mention it is because the person who reported the vulnerability claimed it affects all RubyGems versions, and a fix has already been applied and released for RubyGems itself. I think the fix was simple, so it should be easy to apply.

@lsegal
Copy link
Contributor

lsegal commented Sep 7, 2011

Yep. Again, I'll apply the patch ASAP. The comment was directed at any onlookers worried about their security. Thanks for the heads up, Greg!

@practicingruby
Copy link
Author

Thanks for the quick response. I'll try to report other things if I notice them, though I'm only really lightly involved in RubyGems at the moment.

@lsegal lsegal closed this as completed in eed66a9 Sep 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants