Add endtime field to wpt_events#136
Closed
jbrandligt wants to merge 4 commits into
Closed
Conversation
…and html. startdate and enddate still to come.
Contributor
Author
|
Hey, I did a partial commit of my work so far. Could you have a look and tell me if this is what you had in mind? |
Owner
|
And yes: this is what I had in mind. |
Contributor
Author
|
Ok cool, I'll clean up the code and implement the date methods too then. |
…Date and and time methods are in fact identical to startdate_html and starttime_html methods but left for backward compatibility.
Owner
|
I just merged your code back into mine. |
Contributor
Author
|
Sweet! |
Owner
|
Welcome to the club: https://github.com/slimndap/wp-theatre/graphs/contributors |
slimndap
added a commit
that referenced
this pull request
Jun 28, 2015
* issue-60: wpt_event.php is now PHP CodeSniffer approved. Improved the code of @jbrandligt: - Removed all PHP notices. - Fully deprecated WPT_Event::date() and WPT_Event::time(). - Complete the PHPDocs for the new methods. Startdate and enddate methods implemented too and some code cleanup. Date and and time methods are in fact identical to startdate_html and starttime_html methods but left for backward compatibility. Added tests that confirm the lack of support for {{starttime}}, {{startdate}}, {{endtime}} and {{enddate}} placeholders. See #60 and #136. Partial commit, starttime and endtime methods implemented, both text and html. startdate and enddate still to come. New approach on endtime method, work in progress... Add endtime field to wpt_events Conflicts: functions/wpt_event.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.