Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim 4 support and PSR-15 #104

Closed
wants to merge 7 commits into from

Conversation

@t0mmy742
Copy link

commented Sep 5, 2019

Added support for Slim 4 and PSR-15 (implements MiddlewareInterface).

Also updated composer.json to fit our needs (Slim 4 and PHP set to ^7.1)
Added type-hinting and PHPUnit tests.

I'm using slim/psr7 for tests, but only AppFactory::determineResponseFactory() in source code to let users keep their own providers.

Resolve #102

thomas-lb added 4 commits Sep 4, 2019

@t0mmy742 t0mmy742 force-pushed the t0mmy742:slim-4 branch from 85bb736 to fe8053c Sep 5, 2019

@t0mmy742 t0mmy742 changed the title Slim 4 Slim 4 support and PSR-15 Sep 5, 2019

thomas-lb added 2 commits Sep 5, 2019
README.md Outdated Show resolved Hide resolved
"slim/slim": "~3.0",
"phpunit/phpunit": "^4.0"
"phpunit/phpunit": "^7.5",
"slim/psr7": "^0.5.0"

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate Sep 6, 2019

Contributor

We don't need Slim/psr7 as a dependency. We can use prophecies to write the unit tests.

*/
public function setUp()
public function setUp(): void

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate Sep 6, 2019

Contributor

As mentioned in my previous comment, we should use prophecies instead of using an actual implementation to test. I can rewrite the tests for this if you're not quite familiar with that.

This comment has been minimized.

Copy link
@t0mmy742

t0mmy742 Sep 6, 2019

Author

If you can, yes, I prefer if you rewrite the tests 😄.

@t0mmy742 t0mmy742 requested a review from l0gicgate Sep 6, 2019

thomas-lb
@l0gicgate l0gicgate referenced this pull request Sep 9, 2019
0 of 1 task complete
@l0gicgate

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Follow in #105

@l0gicgate l0gicgate closed this Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.