Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteCollector add optional cacheFile parameter to constructor #2688

Closed
bednic opened this issue May 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@bednic
Copy link

commented May 10, 2019

RouteCollector has method setCacheFile accepting string path, but this cost additional calls in setup of application, it's not possible set cache file trough DI simply. If constructor will contain optional cacheFile parameter it will much simpler. I mean now it's not impossible but tough, much more line of codes 🙂

@l0gicgate

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

I'm open to that for sure. Feel free to raise a PR. We can add it as the last parameter of the current constructor.

@l0gicgate l0gicgate added the Slim 4 label May 12, 2019

@l0gicgate l0gicgate added this to the 4.0.0-beta milestone May 12, 2019

bednic added a commit to bednic/Slim that referenced this issue May 12, 2019

@l0gicgate l0gicgate closed this May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.