Slim 4 Beta Release Feedback

[l0gicgate]

Slim 4 Beta Release
See the full release notes. You may also look at the Alpha release notes for more details about this major release.

Before doing anything read the docs
I just finished the first draft of the docs for Slim 4 which are available here. I need feedback please:
http://dev.slimframework.com/docs/v4

Download and test the 4.0.0-beta release
You may also play around with the 4.x branch and create a simple app with it to test things out.
composer require slim/slim:4.0.0-beta

Install a PSR-7 Implementation
You will also need to install a PSR-7 implementation and ServerRequestCreator combo. You can use Slim's PSR-7 Implementation or choose one of the ones described on the 4.x branch README: https://github.com/slimphp/Slim/blob/4.x/README.md
composer require slim/psr7

If you have any questions don't hesitate to ping me on Slack or ask questions in this thread directly, I'm available to help!

[incisakura]

follow #2653 (comment)

<?php
use Slim\Http\Decorators\ServerRequestDecorator;
use Slim\Factory\ServerRequestCreatorFactory;
use DI\Container;
use Slim\Factory\AppFactory;
use Slim\Interfaces\RouteCollectorProxyInterface as RouteCollectorProxy;

$container = new Container();
AppFactory::setContainer($container);
$app = AppFactory::create();

$app->group('/user', function (RouteCollectorProxy $group) {
    $group->put('/ticket/{id}', UserController::class . ':ticket_update');
}

$serverRequestCreator = ServerRequestCreatorFactory::create();
$request = $serverRequestCreator->createServerRequestFromGlobals();
$request = new ServerRequestDecorator($request);
$response = $app->handle($request);

class UserController
{
    public function update($request, $response, $args)
    {
        $content = $request->getParam('content');
        var_dump($content);
        exit();
    }
}

My posted form data is

content: test

But I just got a NULL in response.
Could you tell my is there anything wrong in my code?

[RyanNerd]

@SakuraSa233 The code $content = $request->getParam('content'); should be replaced with:
$content = $request->getParsedBody();

[l0gicgate]

@SakuraSa233 first of all you don’t need to do any of this boilerplate code anymore. Update to 4.0.0-beta and the decoration is done automatically for both request/response objects as long as Slim-Http is installed.

Also please make sure you’re using the latest version of Slim-Http as there have been some recent changes.

From the code I see, the decoration should work though and getParam() should work but not for the purpose you’re intending to use. As @RyanNerd pointed out you need to use $request->getParsedBodyParam(‘content’) and it should return test.

[incisakura]

I tried it on slim/slim:4.x-dev 06682f1 and slim/http:dev-master 473a811. But all the result is just a NULL or array(0) {}.
In slim/slim:3.x, $request->getParsedBody() would return array(1) {["content"]=>string(4) "test"}, and getParsedBodyParam('content') would return test as expected.
I don't know where is wrong or I mistook something...

[l0gicgate]

@SakuraSa233 in order for the body to be parsed it needs to be a POST request. In case you want the body to be parsed but use a PUT request you could use the packaged MethodOverrideMiddleware and set the X-Http-Method-Override header from the client side to the value PUT while making a POST request. That will ensure that the body gets parsed but that the PUT route gets invoked from the server side.

Your incoming request should look like this

POST /user/ticket/1 HTTP/1.1
Content-Type: application/x-www-form-urlencoded
X-Http-Method-Override: PUT

Add the method override middleware to your app

<?php
use DI\Container;
use Slim\Factory\AppFactory;
use Slim\Interfaces\RouteCollectorProxyInterface as RouteCollectorProxy;
use Slim\Middleware\MethodOverrideMiddleware;

$container = new Container();
AppFactory::setContainer($container);

// Create App and add MethodOverrideMiddleware
$app = AppFactory::create();
$app->add(MethodOverrideMiddleware::class);

// Add Routes
$app->group('/user', function (RouteCollectorProxy $group) {
    $group->put('/ticket/{id}', UserController::class . ':ticket_update');
}

$app->run();

[incisakura]

Oh!!! That should be this...
Thanks for your patient reply!

[tuupola]

I think the current behaviour is not correct. The X-Http-Method-Override is just a workaround for clients which do not support PUT, PATCH etc methods. Server should support them also when using the real request method.

Example Slim 3 code:

require __DIR__ . "/vendor/autoload.php";

$app = new \Slim\App;

$app->put("/test", function ($request, $response) {
    var_dump($request->getParsedBody());
});

$app->run();

yields:

$ curl "http://127.0.0.1:8080/test" \
    --request PUT \
    --include \
    --header "Content-Type: application/json" \
    --data '{ "foo": "bar", "pop": 66 }'

HTTP/1.1 200 OK
Host: 127.0.0.1:8080
Date: Mon, 20 May 2019 07:43:37 +0000
Connection: close
X-Powered-By: PHP/7.3.0
Content-Type: text/html; charset=UTF-8
Content-Length: 65

array(2) {
  ["foo"]=>
  string(3) "bar"
  ["pop"]=>
  int(66)
}

$ curl "http://127.0.0.1:8080/test" \
    --request POST \
    --include \
    --header "Content-Type: application/json" \
    --header "X-Http-Method-Override: PUT" \
    --data '{ "foo": "bar", "pop": 66 }'

HTTP/1.1 200 OK
Host: 127.0.0.1:8080
Date: Mon, 20 May 2019 07:44:25 +0000
Connection: close
X-Powered-By: PHP/7.3.0
Content-Type: text/html; charset=UTF-8
Content-Length: 65

array(2) {
  ["foo"]=>
  string(3) "bar"
  ["pop"]=>
  int(66)
}

Similar Slim 4 version:

use Slim\Factory\AppFactory;
use Slim\Middleware\RoutingMiddleware;
use Slim\Middleware\MethodOverrideMiddleware;

require __DIR__ . "/../vendor/autoload.php";

$app = AppFactory::create();

$routeResolver = $app->getRouteResolver();
$routingMiddleware = new RoutingMiddleware($routeResolver);
$app->add($routingMiddleware);

$methodOverrideMiddleware= new MethodOverrideMiddleware;
$app->add($methodOverrideMiddleware);

$app->put("/test", function($request, $response, $args) {
    var_dump($request->getParsedBody());
    return $response;
});


$app->run();

yields:

$ curl "http://127.0.0.1:8080/test" \
    --request PUT \
    --include \
    --header "Content-Type: application/json" \
    --data '{ "foo": "bar", "pop": 66 }'

HTTP/1.1 200 OK
Host: 127.0.0.1:8080
Date: Mon, 20 May 2019 07:49:26 +0000
Connection: close
X-Powered-By: PHP/7.3.0
Content-type: text/html; charset=UTF-8

NULL

$ curl "http://127.0.0.1:8080/test" \
    --request POST \
    --include \
    --header "Content-Type: application/json" \
    --header "X-Http-Method-Override: PUT" \
    --data '{ "foo": "bar", "pop": 66 }'
HTTP/1.1 200 OK
Host: 127.0.0.1:8080
Date: Mon, 20 May 2019 08:08:21 +0000
Connection: close
X-Powered-By: PHP/7.3.0
Content-type: text/html; charset=UTF-8

NULL

You can get some output by mimicking an old client which does not support PUT method natively.

$ curl "http://127.0.0.1:8080/test" \
    --request POST \
    --include \
    --header "Content-Type: application/x-www-form-urlencoded" \
    --header "X-Http-Method-Override: PUT" \
    --data '{ "foo": "bar", "pop": 66 }'
HTTP/1.1 200 OK
Host: 127.0.0.1:8080
Date: Mon, 20 May 2019 08:10:26 +0000
Connection: close
X-Powered-By: PHP/7.3.0
Content-type: text/html; charset=UTF-8

array(1) {
  ["{_"foo":_"bar",_"pop":_66_}"]=>
  string(0) ""
}

[l0gicgate]

@tuupola there’s no media parsers in Slim-Psr7. It doesn’t handle JSON by default. As seen in your second last example you’re using application/json as Content-Type. It only supports form data out of the box so only application/x-www-form-urlencoded will work via a POST request. That’s because PHP doesn’t populate the $_POST object unless it’s a POST. If you install Slim-Http decorators then body parsing for JSON content works out of the box on POST requests.

Edit:
I just realized that Slim-Psr7 does not parse any type of bodies by default. Will be adding $_POST and application/json parsers shortly for next pre-release. All that functionality stayed in Slim-Http

[RyanNerd]

@tuupola see this thread to implement an application/json media parser as middleware.

[tuupola]

@l0gicgate Ah of course. Misunderstood the reason why $request->getParsedBody() returned null. Thanks!

[merlindiavova]

Just a quick note
on https://www.slimframework.com/2019/04/25/slim-4.0.0-alpha-release.html#step-4-hello-world

// error
require __DIR__ . '/vendor/autoload.php.'; // there is a trailing dot after .php

// should be 
require __DIR__ . '/vendor/autoload.php'; // no trailing dot after .php