New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove final from Container class #1670

Merged
merged 1 commit into from Dec 10, 2015

Conversation

Projects
None yet
5 participants
@akrabat
Member

akrabat commented Dec 10, 2015

No description provided.

@akrabat akrabat added the Slim 3 label Dec 10, 2015

@akrabat akrabat added this to the 3.1.0 milestone Dec 10, 2015

@geggleto

This comment has been minimized.

Show comment
Hide comment
@geggleto

geggleto Dec 10, 2015

Contributor

YES PLZ! 1000x 👍

Contributor

geggleto commented Dec 10, 2015

YES PLZ! 1000x 👍

silentworks added a commit that referenced this pull request Dec 10, 2015

Merge pull request #1670 from akrabat/final
Remove final from Container class

@silentworks silentworks merged commit 48fb2ce into slimphp:3.x Dec 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 89.668%
Details

@akrabat akrabat added the improvement label Jan 1, 2016

@bradynpoulsen

This comment has been minimized.

Show comment
Hide comment
@bradynpoulsen

bradynpoulsen Jan 3, 2016

Is there a timeline for 3.1 to be released? It's kind of a bummer I can't test against Slim\Container until it is released

bradynpoulsen commented Jan 3, 2016

Is there a timeline for 3.1 to be released? It's kind of a bummer I can't test against Slim\Container until it is released

@mathmarques

This comment has been minimized.

Show comment
Hide comment
@mathmarques

mathmarques Jan 3, 2016

Contributor

@bradynpoulsen You can test, just install the dev version like:

$ composer require slim/slim "3.x-dev"
Contributor

mathmarques commented Jan 3, 2016

@bradynpoulsen You can test, just install the dev version like:

$ composer require slim/slim "3.x-dev"
@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Jan 3, 2016

Member

Currently planning for mid-next week.

Member

akrabat commented Jan 3, 2016

Currently planning for mid-next week.

rivetchip pushed a commit to rivetchip/Slim that referenced this pull request Jan 22, 2017

Merge pull request #1670 from akrabat/final
Remove final from Container class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment