New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getQueryParams #1733

Merged
merged 2 commits into from Feb 6, 2016

Conversation

Projects
None yet
3 participants
@mathmarques
Contributor

mathmarques commented Jan 13, 2016

Empty array returns false but an empty array is valid in this case.

Fix a part of: #1731

Fix getQueryParams
Empty array returns false but an empty array is valid in this case

@silentworks silentworks added the Slim 3 label Jan 13, 2016

@silentworks silentworks modified the milestones: 3.2.0, 3.1.1 Jan 13, 2016

@silentworks silentworks added the bug fix label Jan 13, 2016

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 5, 2016

Member

Can we have a unit test for this please?

Member

akrabat commented Feb 5, 2016

Can we have a unit test for this please?

@akrabat akrabat self-assigned this Feb 5, 2016

@akrabat akrabat merged commit 1850cc8 into slimphp:3.x Feb 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Feb 6, 2016

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 6, 2016

Member

Thanks!

Member

akrabat commented Feb 6, 2016

Thanks!

@akrabat akrabat modified the milestones: 3.2.0, 3.1.1 Feb 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment