New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getParsedBody #1734

Merged
merged 3 commits into from Feb 6, 2016

Conversation

Projects
None yet
4 participants
@mathmarques
Contributor

mathmarques commented Jan 13, 2016

Fix a part of: #1731

The only remaining problem is setting null to parsed body.
Using:

 $request = $request->withParsedBody(null);

Won't take effect.

The only way I see to fix this is setting a flag if the body is already parsed or not.

@AndrewCarterUK

This comment has been minimized.

Show comment
Hide comment
@AndrewCarterUK

AndrewCarterUK Jan 13, 2016

Contributor

http://www.php-fig.org/psr/psr-7/

null, array and object are the allowed values.

You could use false as the 'not here' value but I think that would be messy - would be clearer to introduce a new property that acts as a flag (as you suggested).

Contributor

AndrewCarterUK commented Jan 13, 2016

http://www.php-fig.org/psr/psr-7/

null, array and object are the allowed values.

You could use false as the 'not here' value but I think that would be messy - would be clearer to introduce a new property that acts as a flag (as you suggested).

@silentworks silentworks added this to the 3.1.1 milestone Jan 13, 2016

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 5, 2016

Member

Can we have a unit test for this please?

Member

akrabat commented Feb 5, 2016

Can we have a unit test for this please?

@akrabat akrabat self-assigned this Feb 5, 2016

@akrabat akrabat modified the milestones: 3.2.0, 3.1.1 Feb 6, 2016

@akrabat akrabat merged commit 8944626 into slimphp:3.x Feb 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 6, 2016

Member

Thank you.

Member

akrabat commented Feb 6, 2016

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment