New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the default services from a Provider. #1745

Merged
merged 2 commits into from Feb 11, 2016

Conversation

Projects
None yet
4 participants
@mducharme
Contributor

mducharme commented Jan 26, 2016

By splitting the default Slim Container in 2 (The Container and its associated Service Provider to register services) this allows one to use a custom (Pimple-based) container and still auto-register all required service for Slim.

It does not solve the more generic problem of having a reusable provider (because container-interop does not have a "setter" method to register service) but it is, I believe, one step in the right direction. In other words, this won't work more for general-purpose container, but it at least allows any Pimple container to register Slim services without having to have a bridge to the SlimContainer.

@vlakoff

This comment has been minimized.

Show comment
Hide comment
@vlakoff

vlakoff Feb 8, 2016

Contributor

I agree having the services registered in the container class looked very strange at first glance.

Contributor

vlakoff commented Feb 8, 2016

I agree having the services registered in the container class looked very strange at first glance.

@akrabat akrabat added this to the 3.2.0 milestone Feb 8, 2016

akrabat added a commit to akrabat/Slim that referenced this pull request Feb 11, 2016

@akrabat akrabat merged commit b3a5ddd into slimphp:3.x Feb 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 11, 2016

Member

Thanks.

Member

akrabat commented Feb 11, 2016

Thanks.

@akrabat akrabat added the improvement label Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment