New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP7+ Errors #1770

Merged
merged 1 commit into from Feb 19, 2016

Conversation

Projects
None yet
3 participants
@akrabat
Member

akrabat commented Feb 14, 2016

Implement a new error handler, PhpError which handles PHP 7's new Throwable interface.

This fixes #1762.

Note that I couldn't just use the current Error handler as I'd have had to have changed the method signatures which would have broken BC. I've chosen to catch Throwable in this new handler so that when we go to 4.0, we can simply remove the current Error handler and this one can then be used to catch both Exceptions and PHP 7+ Errors.

Support PHP7+ Errors
Implement a new error handler, `PhpError` which handles PHP 7's new
`Throwable` interface.
@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 14, 2016

Member

Explicit ping for @codeguy & @silentworks :) Thoughts appreciated from everyone else!

Member

akrabat commented Feb 14, 2016

Explicit ping for @codeguy & @silentworks :) Thoughts appreciated from everyone else!

@akrabat akrabat added this to the 3.2.0 milestone Feb 14, 2016

@geggleto

This comment has been minimized.

Show comment
Hide comment
@geggleto

geggleto Feb 15, 2016

Contributor

I like it. But we as we build new features into Slim you can really start to see some of the short-comings.

  1. Hard-coded content-types
  2. No Handler Interfaces

These 2 issues force a user to extend the current class and override the methods instead of simply implementing an interface. I don't think its a big deal breaker, but these sorts of issues should be cataloged somewhere for 4.0

Contributor

geggleto commented Feb 15, 2016

I like it. But we as we build new features into Slim you can really start to see some of the short-comings.

  1. Hard-coded content-types
  2. No Handler Interfaces

These 2 issues force a user to extend the current class and override the methods instead of simply implementing an interface. I don't think its a big deal breaker, but these sorts of issues should be cataloged somewhere for 4.0

@geggleto geggleto referenced this pull request Feb 15, 2016

Open

Slim 4.0 Road Map #1686

silentworks added a commit that referenced this pull request Feb 19, 2016

@silentworks silentworks merged commit 2597d9e into slimphp:3.x Feb 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment