New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class name constant instead of magic string. #1874

Merged
merged 1 commit into from May 16, 2016

Conversation

Projects
None yet
3 participants
@adambro
Contributor

adambro commented May 15, 2016

The MyClass::class constant has fully qualified class name. Available
since PHP 5.5 release for all classes.

Use class name constant instead of magic string.
The MyClass::class constant has fully qualified class name. Available
since PHP 5.5 release for all classes.
@coveralls

This comment has been minimized.

coveralls commented May 15, 2016

Coverage Status

Coverage remained the same at 87.975% when pulling 2a5dc64 on adambro:use_class_constant into 954472c on slimphp:3.x.

@akrabat akrabat added this to the 3.4.1 milestone May 16, 2016

@akrabat akrabat merged commit 2a5dc64 into slimphp:3.x May 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.975%
Details

akrabat added a commit that referenced this pull request May 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment