Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove App::VERSION #2067

Merged
merged 2 commits into from Nov 26, 2016

Conversation

Projects
None yet
4 participants
@codeguy
Copy link
Member

commented Nov 22, 2016

Removes VERSION constant which was never updated.

Also fixes a Error Handler unit test that assumed unix line returns, which was not true when executed on Windows systems.

Fixes #2058

@codeguy codeguy added the Slim 4 label Nov 22, 2016

@codeguy codeguy added this to the 4.0 milestone Nov 22, 2016

@coveralls

This comment has been minimized.

Copy link

commented Nov 22, 2016

Coverage Status

Coverage increased (+0.002%) to 97.259% when pulling 5f6c3ba on codeguy:4.x-remove-version into 686bfc2 on slimphp:4.x.

@codeguy

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2016

/me pings @akrabat

@akrabat akrabat merged commit 5f6c3ba into slimphp:4.x Nov 26, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.259%
Details

akrabat added a commit that referenced this pull request Nov 26, 2016

@akrabat akrabat changed the title 4.x remove version Remove App::VERSION Nov 26, 2016

@vlakoff

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2018

This has been undone later, in #2472.

Thus, there is a line in the changelog that should be removed.

@vlakoff

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2018

(by the way, that's an example it's not good to mix different changes in the same PR :)

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.