Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor container out of router, route, route group #2102

Merged
merged 4 commits into from Dec 20, 2016

Conversation

Projects
None yet
6 participants
@codeguy
Copy link
Member

commented Dec 11, 2016

Work in progress. Do not merge yet. Ready for review.

@coveralls

This comment has been minimized.

Copy link

commented Dec 11, 2016

Coverage Status

Coverage decreased (-0.3%) to 97.337% when pulling 30f22b0 on codeguy:feature-refactor-container-router into 394732e on slimphp:4.x.

@codeguy codeguy added this to the 4.0 milestone Dec 11, 2016

@codeguy codeguy added the Slim 4 label Dec 11, 2016

codeguy added some commits Dec 11, 2016

@coveralls

This comment has been minimized.

Copy link

commented Dec 11, 2016

Coverage Status

Coverage decreased (-0.3%) to 97.328% when pulling 602f096 on codeguy:feature-refactor-container-router into 394732e on slimphp:4.x.

@coveralls

This comment has been minimized.

Copy link

commented Dec 11, 2016

Coverage Status

Coverage decreased (-0.3%) to 97.328% when pulling 602f096 on codeguy:feature-refactor-container-router into 394732e on slimphp:4.x.

@coveralls

This comment has been minimized.

Copy link

commented Dec 11, 2016

Coverage Status

Coverage decreased (-0.3%) to 97.328% when pulling f850464 on codeguy:feature-refactor-container-router into 394732e on slimphp:4.x.

@codeguy codeguy changed the title [WIP] Refactor container out of router, route, route group Refactor container out of router, route, route group Dec 11, 2016

@codeguy codeguy requested a review from akrabat Dec 11, 2016

@codeguy

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2016

Ready for review.

@codeguy

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2016

@akrabat Can you review this when you get a chance?

@akrabat

This comment has been minimized.

Copy link
Member

commented Dec 18, 2016

I expect to be able to review this week.

@akrabat

This comment has been minimized.

Copy link
Member

commented Dec 20, 2016

Is it worth implementing setInvocationStrategy() in Slim 3 so that people can start using it now ready for upgrading?

@akrabat akrabat merged commit f850464 into slimphp:4.x Dec 20, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 97.328%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Dec 20, 2016

@geggleto

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2016

👍 :D

@@ -1,5 +1,7 @@
# How to upgrade

* [2098] - You need to add the App's router to the container for a straight upgrade. If you've created your own router factory in the container though, then you need to set it into the $app.
* [2102] - You must inject custom route invocation strategy with `$app->getRouter()->setDefaultInvocationStrategy($myStrategy)`

This comment has been minimized.

Copy link
@crocodile2u

crocodile2u Dec 21, 2016

Because introduction of a new method to the interface (setDefaultInvocationStrategy) is a BC break for user implementations, it has to be mentioned in the docs as well.

This comment has been minimized.

Copy link
@danopz

danopz Dec 21, 2016

Member

This PR is for Slim4 so BC is implied 😉

This comment has been minimized.

Copy link
@akrabat

akrabat Dec 21, 2016

Member

Yes. UPGRADING.md will be used to create the docs for how to upgrade from 3 to 4.

This comment has been minimized.

Copy link
@crocodile2u

crocodile2u Dec 21, 2016

So it's a proper time to add this info to UPGRADING.md. Smth like "If you're using a custom router implementing Slim\Interfaces\RouterInterface, please note that you will have to implement a new method - setDefaultInvocationStrategy()"

@geggleto

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2017

I would love the change in Slim 3 @akrabat

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.