Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Slim\Exception\SlimException #2124

Merged
merged 5 commits into from Feb 6, 2017

Conversation

Projects
None yet
3 participants
@railto
Copy link

commented Jan 15, 2017

Per issue #2055 this removes Slim\Exception\SlimException by updating MethodNotAllowedException and NotFoundException to extend the \Exception class and pulling in the request and response themselves. Also removed redundant test.

@coveralls

This comment has been minimized.

Copy link

commented Jan 15, 2017

Coverage Status

Coverage decreased (-0.06%) to 97.271% when pulling 1e8151b on railto:feature/2055 into 78c5dab on slimphp:4.x.

@akrabat akrabat added the Slim 4 label Jan 17, 2017

@railto

This comment has been minimized.

Copy link
Author

commented Feb 4, 2017

Not sure how this has caused the test coverage to drop, tho appears to be such a small amount.

@akrabat akrabat added this to the 4.0 milestone Feb 6, 2017

@akrabat akrabat merged commit 1e8151b into slimphp:4.x Feb 6, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.06%) to 97.271%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Feb 6, 2017

@akrabat

This comment has been minimized.

Copy link
Member

commented Feb 6, 2017

Thanks.

@akrabat akrabat changed the title Removes Slim\Exception\SlimException Remove Slim\Exception\SlimException Feb 6, 2017

akrabat added a commit that referenced this pull request Feb 6, 2017

@railto railto deleted the railto:feature/2055 branch Jul 12, 2017

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.