Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Request.php to add LINK/UNLINK HTTP methods #2161

Closed
wants to merge 1 commit into from

Conversation

amreladawy
Copy link

LINK and UNLINK need to be added to allowed methods.

LINK and UNLINK need to be added to allowed methods.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.954% when pulling 448234d on amreladawy:patch-1 into c138554 on slimphp:3.x.

Copy link

@johnhunt johnhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put LINK in alphabetical order in the array to maintain consistency.

@akrabat
Copy link
Member

akrabat commented Mar 8, 2017

Sorry, but a far better solution is to remove the list of validMethods altogether and change filterMethod() to check for a regex of the form:

/^[[:alnum:]!#$%&\'*\/+\-.^_`|~]+$/i

and only throw the InvalidMethodException if the $method doesn't match that regex.

@akrabat akrabat closed this Mar 8, 2017
@amreladawy amreladawy deleted the patch-1 branch March 9, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants