Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP method override middleware #2329

Merged
merged 4 commits into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@danopz
Copy link
Member

commented Nov 4, 2017

HTTP method overriding is already removed from Slim as it was present in Request::getMethod().
So I just added a middleware to resolve #2040.

@coveralls

This comment has been minimized.

Copy link

commented Nov 4, 2017

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling 8f3747f on danopz:4.x into 6e1d776 on slimphp:4.x.

@coveralls

This comment has been minimized.

Copy link

commented Nov 4, 2017

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling df8aa7d on danopz:4.x into 6e1d776 on slimphp:4.x.

@coveralls

This comment has been minimized.

Copy link

commented Nov 5, 2017

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling bebbc97 on danopz:4.x into 6e1d776 on slimphp:4.x.

@akrabat akrabat added the Slim 4 label Nov 26, 2017

@akrabat
Copy link
Member

left a comment

There's no point in calling withMethod() if no method override is found. Please refactor appropriately.

@danopz danopz force-pushed the danopz:4.x branch from bebbc97 to e5ee18f Nov 26, 2017

@coveralls

This comment has been minimized.

Copy link

commented Nov 26, 2017

Coverage Status

Coverage increased (+0.08%) to 94.948% when pulling e5ee18f on danopz:4.x into e52d3ce on slimphp:4.x.

@danopz

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2017

Done

@akrabat akrabat merged commit e5ee18f into slimphp:4.x Dec 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 94.948%
Details

akrabat added a commit that referenced this pull request Dec 23, 2017

@akrabat

This comment has been minimized.

Copy link
Member

commented Dec 23, 2017

Thanks.

@akrabat akrabat added this to the 4.0 milestone Aug 24, 2018

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.