New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression, removing user info with Uri::withUserInfo('') is not clearing password anymore #2332

Merged
merged 1 commit into from Nov 25, 2017

Conversation

Projects
None yet
4 participants
@mahagr
Contributor

mahagr commented Nov 6, 2017

Unfortunately, Slim 3.9 broke redirects with user authority as the password isn't cleared when Uri::withUserInfo('') is called.

Url: user:password@domain.com/path became: Location: //:password@/path.

@coveralls

This comment has been minimized.

coveralls commented Nov 6, 2017

Coverage Status

Coverage decreased (-0.05%) to 93.228% when pulling 3967420 on mahagr:feature/uri-userinfo into f6884a7 on slimphp:3.x.

@akrabat

This comment has been minimized.

Member

akrabat commented Nov 6, 2017

Good catch. Can you provide a test too?

@geggleto

This comment has been minimized.

Contributor

geggleto commented Nov 22, 2017

@mahagr we need a test so we can merge this plz :)

splitbrain added a commit to splitbrain-forks/Slim that referenced this pull request Nov 23, 2017

@splitbrain splitbrain referenced this pull request Nov 23, 2017

Merged

Test for #2332 #2351

@mahagr

This comment has been minimized.

Contributor

mahagr commented Nov 23, 2017

Sorry, I've been super busy lately. Thanks @splitbrain for the test!

@akrabat akrabat merged commit 3967420 into slimphp:3.x Nov 25, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 93.228%
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit to akrabat/Slim that referenced this pull request Nov 25, 2017

danopz added a commit to danopz/Slim-Http that referenced this pull request Nov 26, 2017

@mahagr mahagr deleted the mahagr:feature/uri-userinfo branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment