Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set default_mimetype in finalize() - Slim 4.x #2375

Merged

Conversation

Projects
None yet
4 participants
@RyanNerd
Copy link
Contributor

commented Dec 26, 2017

Closes #2284

[Unrelated] Removed an unused namespace reference.
Note: If merged a separate PR should be created to document this requirement.

Ryan
@coveralls

This comment has been minimized.

Copy link

commented Dec 26, 2017

Coverage Status

Coverage decreased (-0.008%) to 94.94% when pulling 7d9f226 on RyanNerd:do-not-set-default_mimetype-in-finalize into 1306570 on slimphp:4.x.

@geggleto geggleto added the Slim 4 label Jan 22, 2018

@akrabat akrabat referenced this pull request Feb 14, 2018

Closed

Document #2375 #2396

@akrabat akrabat merged commit 7d9f226 into slimphp:4.x Feb 14, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.008%) to 94.94%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Feb 14, 2018

akrabat added a commit to akrabat/Slim that referenced this pull request Feb 14, 2018

@akrabat akrabat added this to the 4.0 milestone Feb 14, 2018

@RyanNerd RyanNerd deleted the RyanNerd:do-not-set-default_mimetype-in-finalize branch Feb 15, 2018

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.