New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getBasePath method to Router #2519

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@chantron
Copy link
Contributor

chantron commented Oct 11, 2018

  • Added docblock for new method
  • Added tests for new method

fixes #1964

Added getBasePath method to Router
* Added docblock for new method
* Added tests for new method
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 11, 2018

Coverage Status

Coverage increased (+0.001%) to 97.815% when pulling 0b3209b on chantron:router-get-base-path into 6d34747 on slimphp:3.x.

@BoGnY

This comment has been minimized.

Copy link

BoGnY commented Nov 19, 2018

👍

@akrabat akrabat added this to the 3.12 milestone Nov 27, 2018

@akrabat

This comment has been minimized.

Copy link
Member

akrabat commented Nov 27, 2018

Thank you.

@akrabat akrabat merged commit 0b3209b into slimphp:3.x Nov 27, 2018

3 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 97.815%
Details

akrabat added a commit to akrabat/Slim that referenced this pull request Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment