Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-7 Implementation Decoupling #2529

Merged
merged 48 commits into from Nov 25, 2018
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
0d6a979
add/remove dependencies and scripts from composer.json
l0gicgate Nov 1, 2018
2f41cd9
update Travis-CI configuration
l0gicgate Nov 1, 2018
72a7abc
update README
l0gicgate Nov 1, 2018
53e3c5e
decouple PSR-7 implementation and remove respond and finalize methods…
l0gicgate Nov 1, 2018
475fbcb
add ResponseEmitter
l0gicgate Nov 1, 2018
39390d8
remove PSR-7 dependant method renderWithBody from AbstractErrorRenderer
l0gicgate Nov 1, 2018
6b45c23
modify base ErrorHandler to use PSR-7 generic methods
l0gicgate Nov 1, 2018
467200d
add ResponseFactory dependency injection in ErrorMiddleware
l0gicgate Nov 1, 2018
2b81dd4
modify request method assertion in MethodOverrideMiddleware
l0gicgate Nov 1, 2018
7e7a3cb
add StreamFactory dependency injection in OutputBufferingMiddleware
l0gicgate Nov 1, 2018
7e5fb3b
refactor entire test suite
l0gicgate Nov 1, 2018
6f4cdf6
add Slim-Http decorators example to README
l0gicgate Nov 1, 2018
a97929d
fix mistake in README example
l0gicgate Nov 1, 2018
bcff3c5
add phpstan.neon.dist config file
l0gicgate Nov 1, 2018
53cbd6f
fix all PHPStan errors
l0gicgate Nov 1, 2018
bc765dd
add ext-simplexml to dev dependencies in composer.json
l0gicgate Nov 1, 2018
bc7017f
remove messages in phpstan config
l0gicgate Nov 1, 2018
0008898
remove tests directory from phpstan command in Travis-CI config
l0gicgate Nov 1, 2018
5859306
fix all Slim phpstan errors
l0gicgate Nov 1, 2018
410fc62
fix README comment blocks in examples
l0gicgate Nov 1, 2018
8489a4e
remove unused/reorder imports
l0gicgate Nov 1, 2018
3bbf997
add PSR7ObjectProvider to decouple Tests from specific PSR7 implement…
l0gicgate Nov 1, 2018
7daa6ed
fix PHPCS errors
l0gicgate Nov 1, 2018
dd12345
add PHP 7.3 to Travis-CI config
l0gicgate Nov 2, 2018
24c6867
add Guzzle PSR7 example to README
l0gicgate Nov 2, 2018
bd85e1b
add test coverage clover to Travis-CI config
l0gicgate Nov 2, 2018
6cdb1cb
fix after_success script for php-coveralls in Travis-CI config
l0gicgate Nov 2, 2018
f13c497
add code coverage driver to PHP 7.1 build
l0gicgate Nov 2, 2018
166ced0
fix coverage clover parameter in Travis-CI config
l0gicgate Nov 2, 2018
6d8d74f
fix Nyholm/psr7 README example
l0gicgate Nov 12, 2018
b842ba1
Merge branch '4.x' of https://github.com/slimphp/Slim into PSR7-Decou…
l0gicgate Nov 19, 2018
9f75486
fix param type in InvocationStrategyInterface
l0gicgate Nov 19, 2018
01ccbfa
fix PHPStan errors
l0gicgate Nov 19, 2018
340cadd
fix PHPStan error
l0gicgate Nov 19, 2018
d575b9a
fix PHPStan error
l0gicgate Nov 19, 2018
b4c57be
fix PHPStan errors
l0gicgate Nov 19, 2018
c168c4a
rename base Test class to TestCase
l0gicgate Nov 25, 2018
2ffaee9
change App constructor function signature to take in ResponseFactoryI…
l0gicgate Nov 25, 2018
c7aa199
fix README to reflect changes made to App constructor and run methods
l0gicgate Nov 25, 2018
3ea27ba
fix import ordering back to alphabetical in RouterInterface
l0gicgate Nov 25, 2018
8d454e2
add comment for variable reassignment in Router to avoid PHPStan warning
l0gicgate Nov 25, 2018
570872d
remove unused commented statement in AppTest::tearDownAfterClass
l0gicgate Nov 25, 2018
ba1621b
add comment for ignored error in PHPStan config
l0gicgate Nov 25, 2018
f909bb1
reorder imports alphabetically in multiple files
l0gicgate Nov 25, 2018
3f8978d
fix line length in App
l0gicgate Nov 25, 2018
1a0d4ba
fix README errors
l0gicgate Nov 25, 2018
e2d7633
remove responseChunkSize setting from App
l0gicgate Nov 25, 2018
a62881b
remove useless parameter reassignment to silence PHPStan in Router
l0gicgate Nov 25, 2018
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

fix line length in App

  • Loading branch information...
l0gicgate committed Nov 25, 2018
commit 3f8978d38c5404b2626993df3ddc1160b668d1d3
@@ -85,8 +85,11 @@ class App implements RequestHandlerInterface
* @param ContainerInterface|null $container
* @param array $settings
*/
public function __construct(ResponseFactoryInterface $responseFactory, ContainerInterface $container = null, array $settings = [])
{
public function __construct(
ResponseFactoryInterface $responseFactory,
ContainerInterface $container = null,
array $settings = []
) {
$this->responseFactory = $responseFactory;
$this->container = $container;
$this->addSettings($settings);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.