Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binding of $this to group() #2560

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@vaga
Copy link

commented Jan 4, 2019

It's my first contribution. 馃帀

Closes #2559

@coveralls

This comment has been minimized.

Copy link

commented Jan 4, 2019

Coverage Status

Coverage decreased (-0.008%) to 97.397% when pulling b755a37 on vaga:remove-app-binding-in-route-group into bcf7df5 on slimphp:4.x.

@akrabat
Copy link
Member

left a comment

Just a minor nitpick on a test name.

Also, please update the CHANGELOG

Show resolved Hide resolved tests/AppTest.php Outdated

@vaga vaga force-pushed the vaga:remove-app-binding-in-route-group branch from 9565d82 to f62f5de Jan 4, 2019

@vaga vaga force-pushed the vaga:remove-app-binding-in-route-group branch from f62f5de to b755a37 Jan 4, 2019

@akrabat akrabat added this to the 4.0 milestone Jan 4, 2019

@mbohal

This comment has been minimized.

Copy link

commented Jan 5, 2019

@akrabat Should I update the https://github.com/slimphp/Slim-Website/tree/gh-pages-4.x to reflect this change?
I'm not sure what is going to happen with the docs when Slim 4 gets released and I do not want to introduce any conflicts.

@akrabat

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

@mbohal Raise a PR against that branch please.

@akrabat akrabat added the Slim 4 label Jan 15, 2019

@akrabat akrabat merged commit b755a37 into slimphp:4.x Jan 23, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.008%) to 97.397%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit to akrabat/Slim that referenced this pull request Jan 23, 2019

@akrabat

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Thanks @vaga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.