Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x Remove Pimple #2587

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
3 participants
@l0gicgate
Copy link
Contributor

commented Feb 22, 2019

Removing Pimple as per discussion in #2585.

@coveralls

This comment has been minimized.

Copy link

commented Feb 22, 2019

Coverage Status

Coverage remained the same at 98.487% when pulling b1cb7c7 on l0gicgate:4.x-RemovePimple into a2f22e1 on slimphp:4.x.

@l0gicgate l0gicgate added the Slim 4 label Feb 22, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Feb 22, 2019

l0gicgate added a commit to l0gicgate/Slim that referenced this pull request Feb 28, 2019

@l0gicgate l0gicgate closed this Mar 2, 2019

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RemovePimple branch Mar 2, 2019

@l0gicgate l0gicgate restored the l0gicgate:4.x-RemovePimple branch Mar 2, 2019

@l0gicgate l0gicgate reopened this Mar 2, 2019

@l0gicgate l0gicgate force-pushed the l0gicgate:4.x-RemovePimple branch from 312dfe4 to b1cb7c7 Mar 2, 2019

@@ -39,8 +37,7 @@ public static function setupBeforeClass()
public function testGetContainer()
{
$pimple = new Pimple();
$container = new Psr11Container($pimple);
$container = new MockContainer();

This comment has been minimized.

Copy link
@akrabat

akrabat Mar 2, 2019

Member

Why have a MockContainer object when we could be using PHPUnit's createMock() ?

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate Mar 2, 2019

Author Contributor

We need to have ArrayAccess implemented on the class unless you want to force usage of the ContainerInterface::set() method

This comment has been minimized.

Copy link
@akrabat

akrabat Mar 2, 2019

Member

We need to have ArrayAccess implemented on the class

Why? Slim doesn't set anything into the container anymore does it?

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate Mar 2, 2019

Author Contributor

I misread your question. We can mock a container for that specific test sure. We have a MockContainer though so why not use it

This comment has been minimized.

Copy link
@akrabat

akrabat Mar 2, 2019

Member

Why do we have a MockContainer though? We shouldn't need it as we should be able to use PHPUnit's Mocking functionality for every situation where Slim's classes use a container. If we can't then we need to look at that particular Slim code.

@l0gicgate

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

Will refactor with Mocks instead and re-open.

@l0gicgate l0gicgate closed this Mar 2, 2019

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RemovePimple branch Apr 2, 2019

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.