Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x Refactor RouteGroup & Route #2612

Merged
merged 9 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@l0gicgate
Copy link
Contributor

commented Mar 19, 2019

This is pull 1 out of 7 to complete the goals set in #2604

  • Refactor RouteGroup so it doesn't extend Routable
  • Implement appendMiddlewareToDispatcher() method to avoid encapsulation leakage
  • Refactor Route::finalize() and fold it into Route::run()
  • Remove Routable as it is now obsolete.

This PR effectively closes #2598, #2599 and #2600.

  • Discussion
  • Write Tests

@l0gicgate l0gicgate added the Slim 4 label Mar 19, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Mar 19, 2019

@l0gicgate l0gicgate changed the title [DRAFT] 4.x Refactor RouteGroup [DRAFT] 4.x Refactor RouteGroup & Route Mar 19, 2019

@l0gicgate l0gicgate requested a review from akrabat Mar 19, 2019

@l0gicgate l0gicgate referenced this pull request Mar 19, 2019

Closed

[DRAFT] 4.x Refactor Routing #2604

7 of 7 tasks complete
Show resolved Hide resolved Slim/Route.php Outdated
@akrabat

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Looks reasonable to me.

@l0gicgate l0gicgate marked this pull request as ready for review Mar 21, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 21, 2019

Coverage Status

Coverage remained the same at 98.485% when pulling 5a1d90f on l0gicgate:4.x-RefactorRouteGroup into a36fc2f on slimphp:4.x.

@l0gicgate l0gicgate requested a review from akrabat Mar 21, 2019

@l0gicgate l0gicgate changed the title [DRAFT] 4.x Refactor RouteGroup & Route 4.x Refactor RouteGroup & Route Mar 25, 2019

@akrabat

akrabat approved these changes Apr 2, 2019

@akrabat

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Do we need a CHANGELOG entry?

@l0gicgate

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@akrabat yeah I think so. The public interface has changed for both Route and RouteGroup so I'll add an entry.

@akrabat akrabat merged commit 5a1d90f into slimphp:4.x Apr 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.485%
Details

akrabat added a commit that referenced this pull request Apr 2, 2019

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RefactorRouteGroup branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.