Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface #2622

Merged
merged 21 commits into from Apr 17, 2019

Conversation

@l0gicgate
Copy link
Contributor

l0gicgate commented Apr 2, 2019

This is pull 2 out of 7 to complete the goals set in #2604

  • Split RouterInterface into RouteCollectorInterface and RouteResolverInterface

  • Rename RouteDispatcher to RouteRunner

  • Move all routing components into new Slim\Routing aggregate folder

  • Discussion

  • Write Tests

@l0gicgate l0gicgate added the Slim 4 label Apr 2, 2019
@l0gicgate l0gicgate added this to the 4.0 milestone Apr 2, 2019
@l0gicgate l0gicgate requested a review from akrabat Apr 2, 2019
@l0gicgate l0gicgate mentioned this pull request Apr 2, 2019
7 of 7 tasks complete
@akrabat

This comment has been minimized.

Copy link
Member

akrabat commented Apr 8, 2019

Should the namespace be Slim\Router ?

@l0gicgate

This comment has been minimized.

Copy link
Contributor Author

l0gicgate commented Apr 8, 2019

Should the namespace be Slim\Router ?

I think Slim\Routing is better imo. A router would be a single component, routing is synonymous of all the components being used.

@akrabat

This comment has been minimized.

Copy link
Member

akrabat commented Apr 8, 2019

I think Slim\Routing is better imo. A router would be a single component, routing is synonymous of all the components being used.

The combination of the classes is the router. I don't care enough though, so Routing it is unless someone else has a compelling opinion.

@l0gicgate l0gicgate changed the title [DRAFT] 4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface 4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface Apr 10, 2019
@l0gicgate l0gicgate marked this pull request as ready for review Apr 10, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 10, 2019

Coverage Status

Coverage increased (+0.03%) to 98.512% when pulling fd90436 on l0gicgate:4.x-SplitRouter into 821d563 on slimphp:4.x.

Slim/App.php Outdated Show resolved Hide resolved
@akrabat akrabat merged commit fd90436 into slimphp:4.x Apr 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 98.512%
Details
akrabat added a commit that referenced this pull request Apr 17, 2019
Closes #2622
@l0gicgate l0gicgate deleted the l0gicgate:4.x-SplitRouter branch Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.