Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Route InvocationStrategy Setter #2634

Merged
merged 5 commits into from Apr 20, 2019

Conversation

Projects
None yet
3 participants
@l0gicgate
Copy link
Contributor

commented Apr 17, 2019

This is pull 3 out of 7 to complete the goals set in #2604

This PR adds the capability to set a Route's invocation strategy per route.

Closes #2597

Example usage:

use Slim\App;
use Slim\Handlers\Strategies\RequestResponse;

$app = new App(...);

$invocationStrategy = new RequestResponse();
$app
    ->get('/', function () {...})
    ->setInvocationStrategy(...);

@l0gicgate l0gicgate added the Slim 4 label Apr 17, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Apr 17, 2019

@l0gicgate l0gicgate requested a review from akrabat Apr 17, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 17, 2019

Coverage Status

Coverage increased (+0.004%) to 98.516% when pulling 2cf746c on l0gicgate:4.x-RouteInvocationStrategySetter into 8e07064 on slimphp:4.x.

@l0gicgate l0gicgate requested a review from akrabat Apr 19, 2019

@akrabat akrabat merged commit 2cf746c into slimphp:4.x Apr 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 98.516%
Details

akrabat added a commit that referenced this pull request Apr 20, 2019

@l0gicgate l0gicgate referenced this pull request Apr 20, 2019

Closed

[DRAFT] 4.x Refactor Routing #2604

7 of 7 tasks complete

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RouteInvocationStrategySetter branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.