Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Decouple FastRoute Dispatcher From RouteResolver #2639

Merged
merged 10 commits into from Apr 20, 2019

Conversation

Projects
None yet
2 participants
@l0gicgate
Copy link
Contributor

commented Apr 20, 2019

This is pull 5 out of 7 to complete the goals set in #2604

This decouples the FastRoute dispatcher implementation from RouteResolver. It introduces a new DispatcherInterface so we can implement routers/dispatchers from other frameworks.

This gives a user the ability to implement their own dispatcher, as long as it returns RoutingResults and provide functionality to get the allowed methods for a given uri string.

@l0gicgate l0gicgate added the Slim 4 label Apr 20, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Apr 20, 2019

@l0gicgate l0gicgate referenced this pull request Apr 20, 2019

Closed

[DRAFT] 4.x Refactor Routing #2604

7 of 7 tasks complete
@coveralls

This comment has been minimized.

Copy link

commented Apr 20, 2019

Coverage Status

Coverage increased (+0.009%) to 98.536% when pulling 1ce3288 on l0gicgate:4.x-DecoupleFastRouteDispatching into d5497de on slimphp:4.x.

@l0gicgate l0gicgate merged commit f1b45ef into slimphp:4.x Apr 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 98.536%
Details

@l0gicgate l0gicgate deleted the l0gicgate:4.x-DecoupleFastRouteDispatching branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.