Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions for possible PSR-7 implementations to composer.json #2674

Merged

Conversation

Projects
None yet
3 participants
@michaelbiberich
Copy link

commented Apr 29, 2019

References: #2653, specifically this comment.

@michaelbiberich michaelbiberich changed the title Add suggestions for possible PSR-7 implementations `to composer.json` Add suggestions for possible PSR-7 implementations to composer.json Apr 29, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 29, 2019

Coverage Status

Coverage remained the same at 99.325% when pulling 249a585 on michaelbiberich:suggestions-for-psr7-implementations into 4b6f030 on slimphp:4.x.

@l0gicgate
Copy link
Contributor

left a comment

I think that we should suggest Slim PSR-7 only and provide a link to the docs instead for more repos maybe?

"suggest": {
    "slim/psr7": "Slim PSR-7 implementation. See http://dev.slimframework.com/docs/v4/start/installation.html for more information.",
}
Add suggestions for Slim PSR-7 implementation in `composer.json`
References official docs for further information.
@michaelbiberich

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

The requested changes have been addressed in aa6f672.

Show resolved Hide resolved composer.json Outdated
Replace dev URL to docs in suggestion with production URL to docs
Will 404 for now but prevent another PR to be created on release of v4.
@l0gicgate

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Thank you!

@l0gicgate l0gicgate merged commit af2bf95 into slimphp:4.x Apr 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.325%
Details

@l0gicgate l0gicgate added this to the 4.0.0-beta milestone Apr 29, 2019

@l0gicgate l0gicgate added the Slim 4 label Apr 29, 2019

@l0gicgate l0gicgate referenced this pull request May 19, 2019

Merged

Slim 4 Beta Release #2696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.