Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Psr17Factory Provider & Slim-Http Auto-Detection #2683

Merged
merged 10 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@l0gicgate
Copy link
Contributor

commented May 8, 2019

This PR is to enable users to provide their own set of PSR-17 factories to the AppFactory component.

It also adds Slim-Http auto-detection which automatically instantiates the DecoratedResponseFactory and automatically decorates the ServerRequest object incoming from the ServerRequestCreator that has been detected by ServerRequestCreatorFactory.

Note that automatic decoration can be disabled via these methods:

  • AppFactory::setSlimHttpDecoratorsAutomaticDetection()
  • ServerRequestCreatorFactory::setSlimHttpDecoratorsAutomaticDetection()

In order for Slim-Http auto-detection to work you have to ensure it is installed:

composer require slim/http

@l0gicgate l0gicgate added the Slim 4 label May 8, 2019

@l0gicgate l0gicgate added this to the 4.0.0-beta milestone May 8, 2019

@coveralls

This comment has been minimized.

Copy link

commented May 8, 2019

Coverage Status

Coverage increased (+0.04%) to 99.362% when pulling a420955 on l0gicgate:4.x-Psr17FactoryProvider into 8e939b9 on slimphp:4.x.

@l0gicgate l0gicgate force-pushed the l0gicgate:4.x-Psr17FactoryProvider branch from be64e00 to 82f04bd May 8, 2019

@l0gicgate l0gicgate force-pushed the l0gicgate:4.x-Psr17FactoryProvider branch from 82f04bd to a420955 May 8, 2019

@l0gicgate l0gicgate merged commit bf54fd2 into slimphp:4.x May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@l0gicgate l0gicgate deleted the l0gicgate:4.x-Psr17FactoryProvider branch May 8, 2019

@l0gicgate l0gicgate referenced this pull request May 19, 2019

Merged

Slim 4 Beta Release #2696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.