Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cacheFile to RouteCollector constructor #2689

Merged
merged 2 commits into from May 12, 2019

Conversation

Projects
None yet
3 participants
@bednic
Copy link

commented May 12, 2019

Add cacheFile parametr to class constructor. See #2688

@coveralls

This comment has been minimized.

Copy link

commented May 12, 2019

Coverage Status

Coverage increased (+0.001%) to 99.491% when pulling 4ccda0d on bednic:feature/issue-2688 into a86061f on slimphp:4.x.

) {
$this->responseFactory = $responseFactory;
$this->callableResolver = $callableResolver;
$this->container = $container;
$this->defaultInvocationStrategy = $defaultInvocationStrategy ?? new RequestResponse();
$this->routeParser = $routeParser ?? new RouteParser($this);
if ($cacheFile) {

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate May 12, 2019

Contributor

Please add a line return before this if statement.

/**
* Test cacheFile via construct is set
*/

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate May 12, 2019

Contributor

You can remove this comment block

@l0gicgate l0gicgate added the Slim 4 label May 12, 2019

@l0gicgate l0gicgate added this to the 4.0.0-beta milestone May 12, 2019

@l0gicgate l0gicgate changed the title issue #2688 Add cacheFile to RouteCollector constructor May 12, 2019

@l0gicgate l0gicgate merged commit 2bdc1c1 into slimphp:4.x May 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 99.491%
Details

@l0gicgate l0gicgate referenced this pull request May 19, 2019

Merged

Slim 4 Beta Release #2696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.