Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Add check for Slim callable notation if no resolver given #2807

Closed
wants to merge 3 commits into from

Conversation

@adriansuter
Copy link
Contributor

commented Aug 16, 2019

PR for #2804

The \Slim\DeferredCallable can be instantiated without callable resolver. If the callable is a string, then in many cases, this should work as expected. For example for function names, or ClassName::MethodName notation. But the Slim callable notation ClassName:MethodName would not work. This PR makes sure that we throw an exception if that is the case.

@coveralls

This comment has been minimized.

Copy link

commented Aug 16, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 5975762 on adriansuter:patch-deferred-callable into 8ab3432 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.2.0 milestone Aug 16, 2019

@l0gicgate l0gicgate added the Slim 4 label Aug 16, 2019

@l0gicgate

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

As mentioned in #2804 we should remove DeferredCallable altogether. It's just unnecessary.

@adriansuter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Closing as we should rather remove the DeferredCallable.

@adriansuter adriansuter deleted the adriansuter:patch-deferred-callable branch Aug 18, 2019

@l0gicgate l0gicgate referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.