Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Allow uris with leading multi-slashes #2828

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@adriansuter
Copy link
Contributor

adriansuter commented Sep 5, 2019

This PR closes #2822.

The test case \Slim\Tests\Routing\RouteResolverTest::testComputeRoutingResults() had been modified such that the error message would be understandable if the test fails.

adriansuter added 2 commits Sep 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 80d741c on adriansuter:patch-route-resolver into 5c493cb on slimphp:4.x.

@l0gicgate l0gicgate added the Slim 4 label Sep 5, 2019
@l0gicgate l0gicgate added this to the 4.3.0 milestone Sep 5, 2019
@l0gicgate l0gicgate merged commit 48cb585 into slimphp:4.x Sep 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@adriansuter adriansuter deleted the adriansuter:patch-route-resolver branch Sep 5, 2019
@l0gicgate l0gicgate referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.