Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Refactor `FastRouteDispatcher` #2832

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@adriansuter
Copy link
Contributor

adriansuter commented Sep 9, 2019

This PR does refactor \Slim\Routing\FastRouteDispatcher as there were basically some code duplicates.

So I created a new method routingResults() that tries to find routing results given an http method and a uri. The method would check the static route map as well as the variable route data.

I have removed the protected method routingResultsFromVariableRouteResults() - probably a BC that affects users?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 181d281 on adriansuter:patch-dispatcher into 48cb585 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.3.0 milestone Sep 9, 2019
@l0gicgate l0gicgate added the Slim 4 label Sep 9, 2019
@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Sep 9, 2019

I have removed the protected method routingResultsFromVariableRouteResults() - probably a BC that affects users?

This won't be a BC unless someone extended and overrode.. I'm willing to risk it haha.

Looks much tidier in there now good work!

@l0gicgate l0gicgate merged commit 9c18e47 into slimphp:4.x Sep 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@adriansuter adriansuter deleted the adriansuter:patch-dispatcher branch Sep 11, 2019
@l0gicgate l0gicgate referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.