Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer scripts #2845

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@piotr-cz
Copy link
Contributor

piotr-cz commented Sep 24, 2019

When trying to run composer scripts, instead of executing their file is printed on screen.
For example

composer phpunit
> php vendor/bin/phpunit

dir=$(cd "${0%[/\\]*}" > /dev/null; cd "../phpunit/phpunit" && pwd)

if [ -d /proc/cygdrive ]; then
    case $(which php) in
        $(readlink -n /proc/cygdrive)/*)
            # We are in Cygwin using Windows php, so the path must be translated
            dir=$(cygpath -m "$dir");
            ;;
    esac
fi

"${dir}/phpunit" "$@"

Fixed by adjusting to suggestions:

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 87a1c45 on piotr-cz:bugfix/composer-scripts into 62b7295 on slimphp:4.x.

@l0gicgate l0gicgate added the Slim 4 label Sep 24, 2019
@l0gicgate l0gicgate added this to the 4.3.0 milestone Sep 24, 2019
@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Sep 24, 2019

We should probably fix that on all the repos @adriansuter

@l0gicgate l0gicgate merged commit b63b7d4 into slimphp:4.x Sep 24, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@piotr-cz piotr-cz deleted the piotr-cz:bugfix/composer-scripts branch Sep 24, 2019
@adriansuter

This comment has been minimized.

Copy link
Contributor

adriansuter commented Sep 25, 2019

@l0gicgate Yes, we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.