Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused classes #2853

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@piotr-cz
Copy link
Contributor

piotr-cz commented Oct 1, 2019

As in title

I'm not sure if it's recommended to remove classes that aren't used in code, but docblocks without global namespace such as RuntimeException here.

When running phpstan on tests (vendor\bin\phpstan analyse tests) it doesn't complain about it.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b766563 on piotr-cz:cs/remove-unused-classes into a24fac2 on slimphp:4.x.

@akrabat
akrabat approved these changes Oct 3, 2019
@akrabat akrabat added this to the 4.3.0 milestone Oct 3, 2019
@akrabat akrabat closed this in 8043f51 Oct 3, 2019
@akrabat akrabat merged commit b766563 into slimphp:4.x Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@piotr-cz piotr-cz deleted the piotr-cz:cs/remove-unused-classes branch Oct 3, 2019
@l0gicgate l0gicgate added the Slim 4 label Oct 3, 2019
@l0gicgate l0gicgate referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.