Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined property in tests #2854

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@piotr-cz
Copy link
Contributor

piotr-cz commented Oct 1, 2019

This seems like a dead code (tests don't complain) but I see no reason why not fix it.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 14b5c64 on piotr-cz:bugfix/tests-undefined-property into a24fac2 on slimphp:4.x.

@akrabat
akrabat approved these changes Oct 3, 2019
@akrabat akrabat closed this in 1257d8c Oct 3, 2019
@akrabat akrabat merged commit 14b5c64 into slimphp:4.x Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@piotr-cz piotr-cz deleted the piotr-cz:bugfix/tests-undefined-property branch Oct 3, 2019
@l0gicgate l0gicgate added this to the 4.3.0 milestone Oct 5, 2019
@l0gicgate l0gicgate added the Slim 4 label Oct 5, 2019
@l0gicgate l0gicgate referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.