Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-di/php-di added in composer -> suggest #2869

Merged
merged 3 commits into from Nov 12, 2019
Merged

Conversation

@shahariaazam
Copy link
Contributor

shahariaazam commented Oct 21, 2019

No description provided.

We need to give proper hints where possible for the developer specially who are newbie. So they can get started with appropriate tools and library.
For the documentation `http://www.slimframework.com/docs/v4/concepts/di.html`. Most of the people will start using implementing Container without installing any container library. So I guess, it would be great to show suggestions for the developer to install DI bridge  to work with container.
@shahariaazam shahariaazam changed the title php-di/slim-bridge added in composer -> suggest php-di/php-di added in composer -> suggest Oct 21, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 0959d76 on shahariaazam:4.x into 26020e9 on slimphp:4.x.

@@ -76,6 +76,6 @@
"ext-simplexml": "Needed to support XML format in BodyParsingMiddleware",
"ext-xml": "Needed to support XML format in BodyParsingMiddleware",
"slim/psr7": "Slim PSR-7 implementation. See http://www.slimframework.com/docs/v4/start/installation.html for more information.",
"php-di/slim-bridge": "PHP-DI bridge library is essential to use container in Slim"
"php-di/php-di": "PHP-DI bridge library is needed to use container in Slim"

This comment has been minimized.

Copy link
@l0gicgate

l0gicgate Oct 23, 2019

Contributor

PHP-DI bridge library is needed to use container in Slim

PHP-DI is the recommended container library to be used with Slim

@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Nov 4, 2019

Please make the appropriate changes and resolve the conflicts and I will merge. Thanks

@l0gicgate l0gicgate added the Slim 4 label Nov 12, 2019
@l0gicgate l0gicgate added this to the 4.4.0 milestone Nov 12, 2019
@l0gicgate l0gicgate merged commit 4360365 into slimphp:4.x Nov 12, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@l0gicgate l0gicgate mentioned this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.