Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit type-hint #2871

Merged
merged 1 commit into from Oct 31, 2019
Merged

Remove explicit type-hint #2871

merged 1 commit into from Oct 31, 2019

Conversation

@adriansuter
Copy link
Contributor

adriansuter commented Oct 31, 2019

The explicit type-hint can be removed as it can be inferred from \Psr\Http\Server\RequestHandlerInterface::handle().

The explicit type-hint can be removed as it can be inferred.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 301a182 on adriansuter:patch-type-hint into 534fe00 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.4.0 milestone Oct 31, 2019
@l0gicgate l0gicgate added the Slim 4 label Oct 31, 2019
@l0gicgate l0gicgate merged commit 7f36c9e into slimphp:4.x Oct 31, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@adriansuter adriansuter deleted the adriansuter:patch-type-hint branch Oct 31, 2019
@l0gicgate l0gicgate mentioned this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.