Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `null` to param type-hints #2874

Conversation

@adriansuter
Copy link
Contributor

adriansuter commented Nov 1, 2019

The last three parameters of the \Slim\Routing\RouteCollector constructor can be null. So this PR would update the docblock type-hints accordingly.

public function __construct(
ResponseFactoryInterface $responseFactory,
CallableResolverInterface $callableResolver,
?ContainerInterface $container = null,
?InvocationStrategyInterface $defaultInvocationStrategy = null,
?RouteParserInterface $routeParser = null,
?string $cacheFile = null
) {

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling fc6531e on adriansuter:patch-route-collector-constructor-docblock into 7f36c9e on slimphp:4.x.

@l0gicgate l0gicgate added the Slim 4 label Nov 1, 2019
@l0gicgate l0gicgate added this to the 4.4.0 milestone Nov 1, 2019
@l0gicgate l0gicgate merged commit 624dd0b into slimphp:4.x Nov 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@adriansuter adriansuter deleted the adriansuter:patch-route-collector-constructor-docblock branch Nov 1, 2019
@l0gicgate l0gicgate mentioned this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.