Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render errors uniformly #2896

Merged
merged 3 commits into from Dec 22, 2019
Merged

Render errors uniformly #2896

merged 3 commits into from Dec 22, 2019

Conversation

@adbrvn
Copy link
Contributor

adbrvn commented Dec 12, 2019

In this PR solved several problems

  • Render error uniformly in different formats (#2746)
  • Render http exceptions as custom error pages
  • Hide backtraces in plain format too
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 12, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a04e476 on adbrvn:4.x into 941828c on slimphp:4.x.

@l0gicgate l0gicgate requested a review from adriansuter Dec 17, 2019
@l0gicgate l0gicgate added the Slim 4 label Dec 17, 2019
@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Dec 17, 2019

This is great, thank you for this contribution.

@l0gicgate l0gicgate added this to the 4.4.0 milestone Dec 17, 2019
Copy link
Contributor

adriansuter left a comment

Great, thanks. Only two minor issues.

tests/Error/AbstractErrorRendererTest.php Outdated Show resolved Hide resolved
tests/Error/AbstractErrorRendererTest.php Outdated Show resolved Hide resolved
@adbrvn adbrvn force-pushed the adbrvn:4.x branch from 34b9ded to 5e750a3 Dec 20, 2019
@adriansuter

This comment has been minimized.

Copy link
Contributor

adriansuter commented Dec 20, 2019

Travis fails because of prophecy - see #2901

@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Dec 20, 2019

This PR is good to go. We just need to wait for #2901 to merge

@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Dec 20, 2019

@adriansuter we could prophesize the tests also instead of using mockbuilder for uniformity. We have time since we have to wait anyway. What do you think? I or you can do it since he probably doesn't know how to

@adriansuter

This comment has been minimized.

Copy link
Contributor

adriansuter commented Dec 20, 2019

@l0gicgate Why not, uniformity is always a good thing. I think we will have plenty of time indeed - and then there is also Christmas and New Year coming. Feel free to prophesize the mocks.

* Render error uniformly in different formats
* Render http exceptions as custom error pages
* Hide backtraces in plain format too
@adbrvn adbrvn force-pushed the adbrvn:4.x branch from 5e750a3 to 4f84a8c Dec 21, 2019
l0gicgate added 2 commits Dec 21, 2019
@l0gicgate

This comment has been minimized.

Copy link
Contributor

l0gicgate commented Dec 22, 2019

I'm locking Prophecy version to 1.9 and merging this. We will address issue in #2901. Won't release 4.4.0 until that's resolved.

@l0gicgate l0gicgate merged commit 4b83e02 into slimphp:4.x Dec 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@l0gicgate l0gicgate mentioned this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.