Skip to content

Fix HttpBadRequestException description - #3253

Merged
l0gicgate merged 2 commits into
slimphp:4.xfrom
jsanahuja:fix-http-bad-request-exception-literal
Mar 7, 2023
Merged

l0gicgate merged 2 commits into
slimphp:4.xfrom
jsanahuja:fix-http-bad-request-exception-literal

Conversation

@jsanahuja

Copy link
Copy Markdown
Contributor

Class Slim\Exception\HttpBadRequestException has a "typo" (a missing space) in $description variable:

protected string $description = 'The server cannot or will not process' .
'the request due to an apparent client error.';

Using getDescription() to display "generic" responses:

image

@l0gicgate l0gicgate added this to the 4.12.0 milestone Mar 7, 2023
@coveralls

coveralls commented Mar 7, 2023 •

Copy link
Copy Markdown

Coverage Status

Coverage: 99.429% (+0.002%) from 99.427% when pulling 591d112 on jsanahuja:fix-http-bad-request-exception-literal into fdf2dab on slimphp:4.x.

@l0gicgate
l0gicgate merged commit 6d05f11 into slimphp:4.x Mar 7, 2023
@l0gicgate

Copy link
Copy Markdown
Member

Thank you for this contribution @jsanahuja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants