Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Nov 8, 2016
•
icgood
requested changes
Nov 8, 2016
Tests look great, just requested a minor tweak on implementation and then you're good to go.
slimta/smtp/server.py
Outdated
| ehlo_as = ehlo_as.decode('utf-8') | ||
| reply = Reply('250', 'Hello '+ehlo_as) | ||
| reply.enhanced_status_code = False | ||
| self._call_custom_handler('EHLO', reply, ehlo_as) |
This comment has been minimized.
This comment has been minimized.
icgood
Nov 8, 2016
Member
I think I'd rather see this implemented as if/elif clauses at the top of the handlers, e.g.
if not self.bannered:
bad_sequence.send(self.io)
return
elif not ehlo_as:
bad_arguments.send(self.io)
return
This comment has been minimized.
This comment has been minimized.
|
Do you want that I rewrite git history in order to melt commits before merging? |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Nov 8, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Nov 8, 2016
•
icgood
approved these changes
Nov 8, 2016
No need to squash commits, I'll do that on merge. This looks great, thanks!
icgood
merged commit d7c5608
into
slimta:master
Nov 8, 2016
toxinu
deleted the
oasiswork:fix-empty-ehlo
branch
Nov 9, 2016
icgood
added this to the 4.0 milestone
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
toxinu commentedNov 8, 2016
Related to #111.
I also add tests.
Feedbacks are welcome!😄