Permalink
Browse files

v1.3.4.297 - address github issue #351 - add yet another delay to fix…

… Spigot
  • Loading branch information...
slipcor committed Dec 20, 2017
1 parent 3fa8cb6 commit e5690d85699d5a4189659471e14ec1e2b1550a8d
Showing with 18 additions and 4 deletions.
  1. +1 −0 doc/changelog.md
  2. +1 −1 readme.md
  3. +16 −3 src/net/slipcor/pvparena/arena/PlayerState.java
View
@@ -1,3 +1,4 @@
+- v1.3.4.297 - address github issue #351 - add yet another delay to fix Spigot
- v1.3.4.296 - address github issue #329 - actually change the scoreboard title :O
- v1.3.4.295 - fix the fact that the scoreboard did not update on losing the last life. Thanks to @Oruss7
- v1.3.4.294 - add team size and total team count when joining
View
@@ -93,7 +93,7 @@ Users tutorials :
## Changelog
-- v1.3.4.296 - address github issue #329 - actually change the scoreboard title :O
+- v1.3.4.297 - address github issue #351 - add yet another delay to fix Spigot
- [read more](doc/changelog.md)
***
@@ -273,10 +273,23 @@ public void reset() {
}
public static void removeEffects(final Player player) {
- for (final PotionEffect pe : player.getActivePotionEffects()) {
- player.removePotionEffect(pe.getType());
+ class RunLater implements Runnable {
+ @Override
+ public void run() {
+ for(final PotionEffect pe :player.getActivePotionEffects())
+ {
+ player.removePotionEffect(pe.getType());
+ }
+ }
+ }
+ try {
+ Bukkit.getScheduler().runTaskLater(PVPArena.instance, new RunLater(), 5L);
+ } catch (Exception e) {
+ for(final PotionEffect pe :player.getActivePotionEffects())
+ {
+ player.removePotionEffect(pe.getType());
+ }
}
-
}
public static PlayerState undump(final YamlConfiguration cfg, final String pName) {

12 comments on commit e5690d8

@mibby

This comment has been minimized.

Show comment
Hide comment
@mibby

mibby Dec 22, 2017

@slipcor This breaks potion effects for me. Players who select the scout class are losing their speed buff.

mibby replied Dec 22, 2017

@slipcor This breaks potion effects for me. Players who select the scout class are losing their speed buff.

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Dec 23, 2017

Contributor

AH !

Contributor

Oruss7 replied Dec 23, 2017

AH !

@mibby

This comment has been minimized.

Show comment
Hide comment
@mibby

mibby Feb 7, 2018

@Oruss7 Do you think you could hot-fix this issue since slipcor is currently dead? Potion effects seem to set fine on initial life but once you die, they never get set back.

mibby replied Feb 7, 2018

@Oruss7 Do you think you could hot-fix this issue since slipcor is currently dead? Potion effects seem to set fine on initial life but once you die, they never get set back.

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Feb 9, 2018

Contributor

@mibby yeah i could try. can you give me an example of arena config plz ?

Contributor

Oruss7 replied Feb 9, 2018

@mibby yeah i could try. can you give me an example of arena config plz ?

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Feb 9, 2018

Contributor

maybe add a little tempo before setting potion effect.

Contributor

Oruss7 replied Feb 9, 2018

maybe add a little tempo before setting potion effect.

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Feb 9, 2018

Contributor

Please try this build: remove ".zip" from the file name, it's only for github don't accept .jar extensions ...
pa_m_betterclasses.jar.zip

Contributor

Oruss7 replied Feb 9, 2018

Please try this build: remove ".zip" from the file name, it's only for github don't accept .jar extensions ...
pa_m_betterclasses.jar.zip

@mibby

This comment has been minimized.

Show comment
Hide comment
@mibby

mibby Feb 10, 2018

@Oruss7 Unfortunately that didn't seem to fix the problem. Upon dying with a class that has a permanent effect, the effect is still not set back on respawn.

You don't think this commit we are commenting on is removing the potion effect after respawning with the 5L delay?

mibby replied Feb 10, 2018

@Oruss7 Unfortunately that didn't seem to fix the problem. Upon dying with a class that has a permanent effect, the effect is still not set back on respawn.

You don't think this commit we are commenting on is removing the potion effect after respawning with the 5L delay?

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Feb 10, 2018

Contributor

After tests, i fix it. I'm pushing and made PR this day.

Contributor

Oruss7 replied Feb 10, 2018

After tests, i fix it. I'm pushing and made PR this day.

@Oruss7

This comment has been minimized.

Show comment
Hide comment
Contributor

Oruss7 replied Feb 10, 2018

@mibby

This comment has been minimized.

Show comment
Hide comment
@mibby

mibby Feb 10, 2018

Thanks Oruss7. I'll update again later today and give it a test. :)

Now if only PA saved item NBT data to the inventory dump like MobArena when disconnecting from within an arena and relogging. :P

Thanks Oruss7. I'll update again later today and give it a test. :)

Now if only PA saved item NBT data to the inventory dump like MobArena when disconnecting from within an arena and relogging. :P

@Oruss7

This comment has been minimized.

Show comment
Hide comment
@Oruss7

Oruss7 Feb 13, 2018

Contributor

it's another problem

Contributor

Oruss7 replied Feb 13, 2018

it's another problem

@mibby

This comment has been minimized.

Show comment
Hide comment
@mibby

mibby Feb 15, 2018

I know, just a pretty big problem due to potential inventory loss. :(

mibby replied Feb 15, 2018

I know, just a pretty big problem due to potential inventory loss. :(

Please sign in to comment.