Skip to content

/DAO

New issue

Withdraw of negative amount from SampleOffer #171

Closed
chfast opened this Issue May 25, 2016 · 2 comments

Labels

None yet

Milestone

No milestone

Assignees

No one assigned

2 participants

@chfast @LefterisJP
@chfast
chfast commented May 25, 2016

You can withdraw negative amount of money from SampleOffer.getDailyPayment() because the calculations ignores historical changes to dailyWithdrawLimit.

@chfast
chfast commented May 25, 2016

@CJentzsch I can send a fix.

@LefterisJP LefterisJP referenced this issue May 25, 2016
Closed

Improve Offer withdraw mechanics #170

@LefterisJP
LefterisJP commented May 25, 2016

Awesome find Pawel :)

@chfast chfast added a commit to imapp-pl/DAO that referenced this issue May 25, 2016
@chfast chfast SampleOffer: fix withdraw negative amount issue 
This fixes the issue slockit#171. Instread of remembering how much was payed out, it is remembered when the last payout was. Type type of withdraw limits has been also changed to uint128 to avoid overflow calculating the amount for the withdraw.
 c7aa328
@chfast chfast referenced this issue May 25, 2016
Merged

SampleOffer: fix withdraw negative amount issue #173

@LefterisJP LefterisJP closed this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.