prevent tokens from being sent to the dao itself #197

p-s-dev · May 30, 2016

No description provided.

CJentzsch · May 30, 2016

why?

D-Nice · May 30, 2016

It dilutes the overall value of tokens, and they won't contribute to votes.

p-s-dev · May 30, 2016

People send on accident, thinking that is how to vote
mist doesn't sum tokens correctly when dao holds them (granted, that is a mist "bug")

p-s-dev · Jun 1, 2016

Currently, people have accidentally sent 56,828 dao tokens (worth ~$7,330) to TheDao.

CJentzsch · Jun 2, 2016

you would allso need that change in transferFrom

p-s-dev · Jun 3, 2016

Done, added to transferFrom() also

p-s-dev prevent tokens from being sent to the dao itself a6aa15a

p-s-dev also check in transferFrom eeee8ab

CJentzsch merged commit 6306b34 into slockit:master Jun 3, 2016

LefterisJP added the enhancement label Jun 3, 2016

LefterisJP added this to the DAO v1.1 milestone Jun 3, 2016

@@ -740,6 +740,7 @@ contract DAO is DAOInterface, Token, TokenCreation {
              if (isFueled
                  && now > closingTime
                  && !isBlocked(msg.sender)
+    +            && _to != address(this)

slockit/DAO